This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update product placeholders with products from design #12007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.53 MB ℹ️ View Unchanged
|
albarin
force-pushed
the
11875/update-dummy-product-images
branch
from
ff1a8e6
to
e780059
Compare
albarin
added
type: enhancement
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
albarin
changed the title
nefeline
reviewed
Dec 1, 2023
nefeline
approved these changes
Dec 1, 2023
|
Registering here for our future reference that the content and images used to update the products on this PR were obtained from the following design for the Product Gallery pattern (which is powered by the Product Collection block): FlPl7fHaGv9mpu8Nfl0joH-fi-158_32452 
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates the dummy products to use real product info and images.
It also reduces the size of one of the images, it was huge in px and close to 1 Mb.
Fixes #11997 (review)
Why
To have real product placeholders instead of dummy empty ones.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
wp-admin/tools.php?page=woocommerce-admin-test-helper.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog